-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SD files not being imported completely #12
Conversation
…s fail to be read by the reader (caused the import to stop); structures imported from SDF are now assigned the file name extended with the index of the structure in the file (formerly the count of successfull imports) if no name of the structure could be detected;
Let me summarise the problem as I understand it: We did not configure the SDF reader to skip erroneous structures before. Which led to the whole import being aborted when an erroneous structure was encountered. Correct? |
This is exactly the problem, if we set "skip" in the Ctor, we cannot log the problematic SDF entries. For me the code is okay. |
And if there are multiple erroneous entries in a row in the input file? They will be skipped together, right? |
Hmmm, yes, but it will lead to the counter of the structures getting faulty... At this point, I might be forced to extend the IteratingSDFReader with a respective counter. |
Exactly my thinking. I would not put priority on this point, rather remove the statement that the counters/indices refer to the position in the input file from the doc. But one possible solution would be to parse the SD file yourself, put everything between two lines of "$$$" in a String/buffer, and then apply the MOL reader to that. If simply extending the IteratingSDFReader does not work. I guess this class does nothing else than what I just described. |
Please don't, it all misses the mark by a long way. Leave the indexation of names as it is and that's it. Anything else would be too much of a good thing. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Quality Gate passedIssues Measures |
Fixed SD files not being imported in their entire length if structures fail to be read by the reader (caused the import to stop); structures imported from SDF are now assigned the file name extended with the index of the structure in the file (formerly the count of successfull imports) if no name of the structure could be detected;
Please review!